lkml.org 
[lkml]   [2013]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/9] backlight: atmel-pwm-bl: clean up get_intensity
On 11:55 Wed 23 Oct     , Johan Hovold wrote:
> Clean up get_intensity to increase readability.
>
> Acked-by: Jingoo Han <jg1.han@samsung.com>
> Signed-off-by: Johan Hovold <jhovold@gmail.com>

this ok
> ---
> drivers/video/backlight/atmel-pwm-bl.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c
> index 52a8134..504061c 100644
> --- a/drivers/video/backlight/atmel-pwm-bl.c
> +++ b/drivers/video/backlight/atmel-pwm-bl.c
> @@ -70,15 +70,14 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd)
> static int atmel_pwm_bl_get_intensity(struct backlight_device *bd)
> {
> struct atmel_pwm_bl *pwmbl = bl_get_data(bd);
> + u32 cdty;
> u32 intensity;
>
> - if (pwmbl->pdata->pwm_active_low) {
> - intensity = pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY) -
> - pwmbl->pdata->pwm_duty_min;
> - } else {
> - intensity = pwmbl->pdata->pwm_duty_max -
> - pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY);
> - }
> + cdty = pwm_channel_readl(&pwmbl->pwmc, PWM_CDTY);
> + if (pwmbl->pdata->pwm_active_low)
> + intensity = cdty - pwmbl->pdata->pwm_duty_min;
> + else
> + intensity = pwmbl->pdata->pwm_duty_max - cdty;
>
> return (u16)intensity;
> }
> --
> 1.8.4
>


\
 
 \ /
  Last update: 2013-10-25 14:01    [W:0.261 / U:2.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site