Messages in this thread | | | Date | Thu, 24 Oct 2013 23:28:29 +0200 (CEST) | From | Guennadi Liakhovetski <> | Subject | Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status |
| |
Hi Vinod
On Thu, 17 Oct 2013, Vinod Koul wrote:
> On Thu, Oct 17, 2013 at 04:27:55PM +0200, Sebastian Andrzej Siewior wrote: > > On Thu, Oct 17, 2013 at 07:37:45AM +0530, Vinod Koul wrote: > > > index 0bc7275..683c380 100644 > > > --- a/include/linux/dmaengine.h > > > +++ b/include/linux/dmaengine.h > > > @@ -45,16 +45,17 @@ static inline int dma_submit_error(dma_cookie_t cookie) > > > > > > /** > > > * enum dma_status - DMA transaction status > > > - * @DMA_SUCCESS: transaction completed successfully > > > + * @DMA_COMPLETE: transaction completed > > > * @DMA_IN_PROGRESS: transaction not yet processed > > > * @DMA_PAUSED: transaction is paused > > > * @DMA_ERROR: transaction failed > > > */ > > > enum dma_status { > > > - DMA_SUCCESS, > > > + DMA_COMPLETE, > > > DMA_IN_PROGRESS, > > > DMA_PAUSED, > > > DMA_ERROR, > > > + DMA_SUCCESS, > > > }; > > > > There are some drivers which compare against == or != DMA_SUCCESS. Shouldn't this > > become > > enum dma_status { > > - DMA_SUCCESS, > > + DMA_COMPLETE = 0, DMA_SUCCESS = 0, > > DMA_IN_PROGRESS, > > DMA_PAUSED, > > DMA_ERROR, > > }; > > > > so nothing breaks during the transition? > Yes i missed it in first place update the patch to fix that
Are you planning to post a fixed version of this patch or you just fix it internally? Would be good to have it posted to be able to ack it and other relevant patches.
Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/
| |