Messages in this thread | | | Date | Thu, 24 Oct 2013 08:29:37 -0700 | Subject | Re: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL() | From | Josh Boyer <> |
| |
On Wed, Oct 23, 2013 at 10:31 PM, Chen Gang <gang.chen@asianux.com> wrote: > For some architectures, tool chain is not smart enough to recognize the > macro with multiple lines (e.g. arc tool chain), and for common ".S" > file, this kind of macro is also rarely used. > > So expand the related contents of macro to let it pass compiling (can > use "arc-elf32-objdump -x" to know about it). > > The related error (allmodconfig for arc): > > LD init/built-in.o > kernel/built-in.o: In function `load_module_signing_keys': > kernel/modsign_pubkey.c:66: undefined reference to `modsign_certificate_list' > kernel/modsign_pubkey.c:71: undefined reference to `modsign_certificate_list_end' > kernel/modsign_pubkey.c:67: undefined reference to `modsign_certificate_list_end' > > The related tool chain information: > > [root@gchenlinux linux-next]# arc-elf32-as -v > GNU assembler version 2.23.2 (arc-elf32) using BFD version (GNU Binutils) 2.23.2 > [root@gchenlinux linux-next]# arc-elf32-ld -v > GNU ld (GNU Binutils) 2.23.2 > [root@gchenlinux linux-next]# arc-elf32-gcc -v > Using built-in specs. > COLLECT_GCC=arc-elf32-gcc > COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/arc-elf32/4.8.0/lto-wrapper > Target: arc-elf32 > Configured with: ../gcc/configure --without-header --disable-nls --enable-language=c --disable-threads --disable-shared --enable-werror=no target_configargs=enable_vtable_verify=yes --target=arc-elf32 --with-cpu=arc700 : (reconfigured) ../gcc/configure --disable-nls --enable-language=c --disable-threads --disable-shared --enable-werror=no target_configargs=enable_vtable_verify=yes --target=arc-elf32 --with-cpu=arc700 : (reconfigured) ../gcc/configure --without-header --disable-nls --enable-language=c --disable-threads --disable-shared --enable-werror=no target_configargs=enable_vtable_verify=yes --target=arc-elf32 --with-cpu=arc700 --disable-multilib --with-headers=../newlib/newlib/libc/include > Thread model: single > gcc version 4.8.0 (GCC)
Is this only an issue with using multi-line macro definitions in .S files? The practice of using multi-line macro definitions isn't rare. Look at e.g. include/linux/module.h, and a number of other header files.
This seems like a toolchain bug that should be fixable if it works for other architectures.
josh
| |