lkml.org 
[lkml]   [2013]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] kernel/modsign_certificate.S: use real contents instead of macro GLOBAL()
    On 10/24/2013 02:03 PM, Richard Weinberger wrote:
    > On Thu, Oct 24, 2013 at 7:31 AM, Chen Gang <gang.chen@asianux.com> wrote:
    >> For some architectures, tool chain is not smart enough to recognize the
    >> macro with multiple lines (e.g. arc tool chain), and for common ".S"
    >> file, this kind of macro is also rarely used.
    >
    > Does not "not smart enough" mean than the said toolchain is broken/buggy
    > or is the kernel using an unsupported notation?
    >

    Hmm... maybe my comments is not quite precise, what I want to say is:

    - another architectures tool chain (e.g. arm-linux-gnueabi-) support it.
    but our tool chain (arc-elf32-) will cause issue.

    - in kernel source, excluding "arch/" sub directory, excep this file and one x86 drivers, no one use macro in this way, now.
    and in "arch/arc/" sub-directory, no one use macro in this way, too.
    the related find command: "find | grep "\.S$" | grep -v "/arch/" | grep -v "Documentation" | xargs grep define"

    So at least, for kernel itself, better change the using way (only 2
    areas use the macro, and the macro only contents 2 lines, so it is
    acceptable enough to expand it).


    Anyway, maybe it is also the tool chain's bug (so I include related arc
    tool chain guys in this mail).


    Thanks.

    >> So expand the related contents of macro to let it pass compiling (can
    >> use "arc-elf32-objdump -x" to know about it).
    >>
    >> The related error (allmodconfig for arc):
    >>
    >> LD init/built-in.o
    >> kernel/built-in.o: In function `load_module_signing_keys':
    >> kernel/modsign_pubkey.c:66: undefined reference to `modsign_certificate_list'
    >> kernel/modsign_pubkey.c:71: undefined reference to `modsign_certificate_list_end'
    >> kernel/modsign_pubkey.c:67: undefined reference to `modsign_certificate_list_end'
    >>
    >> The related tool chain information:
    >>
    >> [root@gchenlinux linux-next]# arc-elf32-as -v
    >> GNU assembler version 2.23.2 (arc-elf32) using BFD version (GNU Binutils) 2.23.2
    >> [root@gchenlinux linux-next]# arc-elf32-ld -v
    >> GNU ld (GNU Binutils) 2.23.2
    >> [root@gchenlinux linux-next]# arc-elf32-gcc -v
    >> Using built-in specs.
    >> COLLECT_GCC=arc-elf32-gcc
    >> COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/arc-elf32/4.8.0/lto-wrapper
    >> Target: arc-elf32
    >> Configured with: ../gcc/configure --without-header --disable-nls --enable-language=c --disable-threads --disable-shared --enable-werror=no target_configargs=enable_vtable_verify=yes --target=arc-elf32 --with-cpu=arc700 : (reconfigured) ../gcc/configure --disable-nls --enable-language=c --disable-threads --disable-shared --enable-werror=no target_configargs=enable_vtable_verify=yes --target=arc-elf32 --with-cpu=arc700 : (reconfigured) ../gcc/configure --without-header --disable-nls --enable-language=c --disable-threads --disable-shared --enable-werror=no target_configargs=enable_vtable_verify=yes --target=arc-elf32 --with-cpu=arc700 --disable-multilib --with-headers=../newlib/newlib/libc/include
    >> Thread model: single
    >> gcc version 4.8.0 (GCC)
    >>
    >>
    >> Signed-off-by: Chen Gang <gang.chen@asianux.com>
    >> ---
    >> kernel/modsign_certificate.S | 10 ++++------
    >> 1 files changed, 4 insertions(+), 6 deletions(-)
    >>
    >> diff --git a/kernel/modsign_certificate.S b/kernel/modsign_certificate.S
    >> index 4a9a86d..1967dcd 100644
    >> --- a/kernel/modsign_certificate.S
    >> +++ b/kernel/modsign_certificate.S
    >> @@ -1,12 +1,10 @@
    >> #include <linux/export.h>
    >>
    >> -#define GLOBAL(name) \
    >> - .globl VMLINUX_SYMBOL(name); \
    >> - VMLINUX_SYMBOL(name):
    >> -
    >> .section ".init.data","aw"
    >>
    >> -GLOBAL(modsign_certificate_list)
    >> + .globl VMLINUX_SYMBOL(modsign_certificate_list)
    >> +VMLINUX_SYMBOL(modsign_certificate_list):
    >> .incbin "signing_key.x509"
    >> .incbin "extra_certificates"
    >> -GLOBAL(modsign_certificate_list_end)
    >> + .globl VMLINUX_SYMBOL(modsign_certificate_list_end)
    >> +VMLINUX_SYMBOL(modsign_certificate_list_end):
    >> --
    >> 1.7.7.6
    >> --
    >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    >> the body of a message to majordomo@vger.kernel.org
    >> More majordomo info at http://vger.kernel.org/majordomo-info.html
    >> Please read the FAQ at http://www.tux.org/lkml/
    >
    >
    >


    --
    Chen Gang


    \
     
     \ /
      Last update: 2013-10-24 09:01    [W:4.532 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site