lkml.org 
[lkml]   [2013]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC v2 12/29] PCI/MSI: Introduce pcim_enable_msi*() family helpers
Hello,

On Thu, Oct 24, 2013 at 11:57:40AM +0100, David Laight wrote:
> > > ...would turn into a single helper call....
> > >
> > > rc = pcim_enable_msix_range(adapter->pdev,
> > > adapter->msix_entries,
> > > nvec,
> > > FOO_DRIVER_MINIMUM_NVEC);
> >
> > I haven't looked into any details but, if the above works for most use
> > cases, it looks really good to me.
>
> The one case it doesn't work is where the driver either
> wants the full number or the minimum number - but not
> a value in between.
>
> Might be worth adding an extra parameter so that this
> (and maybe other) odd requirements can be met.
>
> Some static inline functions could be used for the common cases.

If those are edge cases, I don't think it's a big deal no matter what
we do.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-10-24 13:21    [W:1.810 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site