lkml.org 
[lkml]   [2013]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] Input: add regulator haptic driver
From
Date
On Thu, 2013-10-24 at 18:26 +0900, hyunhee.kim wrote:
> Hi,
>
> Thanks for your review.
> I resent patch v3 after removing wrong wrapping.
>
> I made one toggle function because enable/disable functions have redundant codes and another reviewer suggested it.
> Is it better to separate it into two functions?

Linus doesn't like parameters affecting behavior.

Regards
Oliver




\
 
 \ /
  Last update: 2013-10-24 12:41    [W:1.356 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site