Messages in this thread | | | Subject | Re: [PATCH v2] Input: add regulator haptic driver | From | Oliver Neukum <> | Date | Thu, 24 Oct 2013 12:30:09 +0200 |
| |
On Thu, 2013-10-24 at 18:26 +0900, hyunhee.kim wrote: > Hi, > > Thanks for your review. > I resent patch v3 after removing wrong wrapping. > > I made one toggle function because enable/disable functions have redundant codes and another reviewer suggested it. > Is it better to separate it into two functions?
Linus doesn't like parameters affecting behavior.
Regards Oliver
| |