Messages in this thread | | | Date | Thu, 24 Oct 2013 02:39:45 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 02/11] smp: don't warn about csd->flags having CSD_FLAG_LOCK cleared for !wait |
| |
On Thu, Oct 24, 2013 at 10:25:55AM +0100, Jens Axboe wrote: > blk-mq reuses the request potentially immediately, since the most > cache hot is always given out first. This means that rq->csd could > be reused between csd->func() being called and csd_unlock() being > called. This isn't a problem, since we never use wait == 1 for > the smp call function. Add CSD_FLAG_WAIT to be able to tell the > difference, retaining the warning for other cases. > > Cc: Ingo Molnar <mingo@kernel.org> > Signed-off-by: Jens Axboe <axboe@kernel.dk>
Looks fine, but I'd be tempted to just delete the WARN_ON and add a comment similar to the commit message there.
| |