Messages in this thread | | | Date | Wed, 23 Oct 2013 16:22:50 +0100 | From | Greg KH <> | Subject | Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver |
| |
On Wed, Oct 23, 2013 at 05:06:41PM +0200, Michal Marek wrote: > On 23.10.2013 16:14, Frank Haverkamp wrote: > > of course you are right. Let me try again. > > > > I hope this looks better now: > > + dev_info(&pci_dev->dev, "GenWQE driver version: %s %s%u\n", > > + DRV_VERS_STRING, GENWQE_DEVNAME, cd->card_idx); > > ...
Also, _no_ driver should ever be doing this type of "hey, look at me, I'm now loaded!" type syslog spam anymore. It's pointless, and should be abolished where ever possible. That's one reason we have moved to the driver init type functions that make this impossible to do, and if possible, I recommend doing that here as well.
thanks,
greg k-h
| |