lkml.org 
[lkml]   [2013]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing/events: Fix swiotlb tracepoint creation
On Wed, Oct 23, 2013 at 01:32:04PM +0200, Thierry Reding wrote:
> Tracepoints are only created when Xen support is enabled, but they are
> also referenced within lib/swiotlb.c. So unless Xen support is enabled
> the tracepoints will be missing, therefore causing builds to fail. Fix
> this by moving the tracepoint creation to lib/swiotlb.c, which works
> nicely because the Xen swiotlb support selects the generic swiotlb
> support.

Sweet. Thanks!
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/xen/swiotlb-xen.c | 1 -
> lib/swiotlb.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
> index b310810..44af9d8 100644
> --- a/drivers/xen/swiotlb-xen.c
> +++ b/drivers/xen/swiotlb-xen.c
> @@ -43,7 +43,6 @@
> #include <xen/xen-ops.h>
> #include <xen/hvc-console.h>
>
> -#define CREATE_TRACE_POINTS
> #include <trace/events/swiotlb.h>
> /*
> * Used to do a quick range check in swiotlb_tbl_unmap_single and
> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
> index f0d8419..5558706 100644
> --- a/lib/swiotlb.c
> +++ b/lib/swiotlb.c
> @@ -38,6 +38,7 @@
> #include <linux/bootmem.h>
> #include <linux/iommu-helper.h>
>
> +#define CREATE_TRACE_POINTS
> #include <trace/events/swiotlb.h>
>
> #define OFFSET(val,align) ((unsigned long) \
> --
> 1.8.4
>


\
 
 \ /
  Last update: 2013-10-23 16:21    [W:0.048 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site