lkml.org 
[lkml]   [2013]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] drivers/misc: add rawio framework driver
On Tue, Oct 22, 2013 at 06:45:38AM +0100, Greg Kroah-Hartman wrote:
>
> Oh, one more technical thing, you totally fail to document the
> user/kernel api you have just created.

Yes, this is required to be done. Will fix it.

> You are parsing userspace data in ways that I really don't understand at all...

I don't know which specific codes you were talking about.
Overall the driver needs to parse each argument from the user command.
For example: "r iomem 0xff00c020 40", the driver needs parsing out:
r - read (and default width 4 bytes)
iomem - I/O memory
0xff00c020 - the start address to read
40 - length to read



\
 
 \ /
  Last update: 2013-10-22 21:01    [W:0.149 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site