Messages in this thread | | | Subject | Re: [PATCH 1/3] kbuild: Increase kallsyms max symbol length | From | Joe Perches <> | Date | Tue, 22 Oct 2013 09:36:04 -0700 |
| |
On Tue, 2013-10-22 at 08:46 -0700, Andi Kleen wrote: > From: Joe Mario <jmario@redhat.com> > > [AK: This seems like a ticking time bomb even without LTO, > so should be merged now. It causes very weird problems. > Thanks to Joe for tracking them down.] > > With the added postfixes that LTO adds for local > symbols, the longest name in the kernel overflows > the namebuf[KSYM_NAME_LEN] array by two bytes. That name is: > __pci_fixup_resumePCI_VENDOR_ID_SERVERWORKSPCI_DEVICE_ID_SERVERWORKS_HT1000SBquirk_disable_broadcom_boot_interrupt.1488004.672802 > > Double the max symbol name length. [] > diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h > index 6883e19..711a50f 100644 > --- a/include/linux/kallsyms.h > +++ b/include/linux/kallsyms.h > @@ -9,7 +9,7 @@ > #include <linux/kernel.h> > #include <linux/stddef.h> > > -#define KSYM_NAME_LEN 128 > +#define KSYM_NAME_LEN 256
Doesn't doubling seems a tad excessive given the silly length of that symbol above?
| |