Messages in this thread Patch in this message | | | From | Denis Efremov <> | Subject | [PATCH] xfs:xfs_dir2_node.c: pointer use before check for null | Date | Tue, 22 Oct 2013 11:36:15 +0400 |
| |
Reorder of assert and args pointer dereference.
Found by Linux Driver Verification project (linuxtesting.org) - PVS-Studio analyzer.
Signed-off-by: Denis Efremov <yefremov.denis@gmail.com> --- fs/xfs/xfs_dir2_node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_dir2_node.c b/fs/xfs/xfs_dir2_node.c index 4c3dba7..0ba7382 100644 --- a/fs/xfs/xfs_dir2_node.c +++ b/fs/xfs/xfs_dir2_node.c @@ -1365,8 +1365,8 @@ xfs_dir2_leafn_split( * Allocate space for a new leaf node. */ args = state->args; - mp = args->dp->i_mount; ASSERT(args != NULL); + mp = args->dp->i_mount; ASSERT(oldblk->magic == XFS_DIR2_LEAFN_MAGIC); error = xfs_da_grow_inode(args, &blkno); if (error) { -- 1.8.3.1
| |