lkml.org 
[lkml]   [2013]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/9] backlight: atmel-pwm-bl: use gpio_is_valid
    Date
    Use gpio_is_valid rather than open coding the more restrictive != -1
    test.

    Signed-off-by: Johan Hovold <jhovold@gmail.com>
    ---
    drivers/video/backlight/atmel-pwm-bl.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c
    index db68cab..ffc30d2 100644
    --- a/drivers/video/backlight/atmel-pwm-bl.c
    +++ b/drivers/video/backlight/atmel-pwm-bl.c
    @@ -48,7 +48,7 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd)
    pwm_duty = pwmbl->pdata->pwm_duty_min;

    if (!intensity) {
    - if (pwmbl->gpio_on != -1) {
    + if (gpio_is_valid(pwmbl->gpio_on)) {
    gpio_set_value(pwmbl->gpio_on,
    0 ^ pwmbl->pdata->on_active_low);
    }
    @@ -57,7 +57,7 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd)
    } else {
    pwm_channel_enable(&pwmbl->pwmc);
    pwm_channel_writel(&pwmbl->pwmc, PWM_CUPD, pwm_duty);
    - if (pwmbl->gpio_on != -1) {
    + if (gpio_is_valid(pwmbl->gpio_on)) {
    gpio_set_value(pwmbl->gpio_on,
    1 ^ pwmbl->pdata->on_active_low);
    }
    @@ -146,7 +146,7 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev)
    if (retval)
    return retval;

    - if (pwmbl->gpio_on != -1) {
    + if (gpio_is_valid(pwmbl->gpio_on)) {
    retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on,
    "gpio_atmel_pwm_bl");
    if (retval)
    @@ -196,7 +196,7 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev)
    {
    struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev);

    - if (pwmbl->gpio_on != -1) {
    + if (gpio_is_valid(pwmbl->gpio_on)) {
    gpio_set_value(pwmbl->gpio_on,
    0 ^ pwmbl->pdata->on_active_low);
    }
    --
    1.8.4


    \
     
     \ /
      Last update: 2013-10-22 20:01    [W:4.592 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site