lkml.org 
[lkml]   [2013]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's
From
Date

Hi,

On Tue, 2013-10-22 at 15:32 +0100, Mark Rutland wrote:
> [...]
>
> > > > + phy->sleep_a_clk = devm_clk_get(phy->dev, "sleep_a");
> > >
> > > What means the "_a" in clock name?
> >
> > They are 2 PHY's on 8074 chip. This drivers is supposed to
> > operate on PHY 0, thus sleep_a. PHY 1 is using sleep_b. Take a look
> > here http://www.spinics.net/lists/arm-kernel/msg276945.html
>
> When you say two PHYs, do you mean the HS PHY and the SS PHY?
>
> Or are there two HS PHYs? If so, would the other HS PHY have a sleep_b clock?

I think that this is the case.

>
> The clock-names property should describe the clocks from the view of the device
> itself. As we're describing the PHY in isolation, rather than a big block that
> contains the PHY, the presesnce or absence of other PHYs should not affect the
> name. If the "_a" suffix is only to differentiate the instance of PHY, it
> should be dropped.


Ok. This was left from earlier platform code. I will change it.

Thanks,
Ivan

>
> Thanks,
> Mark.
> --




\
 
 \ /
  Last update: 2013-10-22 18:01    [W:0.037 / U:1.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site