lkml.org 
[lkml]   [2013]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 127/149] powerpc/pseries/lparcfg: Fix possible overflow are more than 1026
    3.2.52-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Chen Gang <gang.chen@asianux.com>

    commit 5676005acf26ab7e924a8438ea4746e47d405762 upstream.

    need set '\0' for 'local_buffer'.

    SPLPAR_MAXLENGTH is 1026, RTAS_DATA_BUF_SIZE is 4096. so the contents of
    rtas_data_buf may truncated in memcpy.

    if contents are really truncated.
    the splpar_strlen is more than 1026. the next while loop checking will
    not find the end of buffer. that will cause memory access violation.

    Signed-off-by: Chen Gang <gang.chen@asianux.com>
    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/powerpc/kernel/lparcfg.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/arch/powerpc/kernel/lparcfg.c
    +++ b/arch/powerpc/kernel/lparcfg.c
    @@ -375,6 +375,7 @@ static void parse_system_parameter_strin
    __pa(rtas_data_buf),
    RTAS_DATA_BUF_SIZE);
    memcpy(local_buffer, rtas_data_buf, SPLPAR_MAXLENGTH);
    + local_buffer[SPLPAR_MAXLENGTH - 1] = '\0';
    spin_unlock(&rtas_data_buf_lock);

    if (call_status != 0) {


    \
     
     \ /
      Last update: 2013-10-21 11:21    [W:4.028 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site