lkml.org 
[lkml]   [2013]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 030/149] USB: mos7720: use GFP_ATOMIC under spinlock
    3.2.52-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit d0bd9a41186e076ea543c397ad8a67a6cf604b55 upstream.

    The write_parport_reg_nonblock() function shouldn't sleep because it's
    called with spinlocks held.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Johan Hovold <jhovold@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/serial/mos7720.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/serial/mos7720.c
    +++ b/drivers/usb/serial/mos7720.c
    @@ -383,7 +383,7 @@ static int write_parport_reg_nonblock(st
    kfree(urbtrack);
    return -ENOMEM;
    }
    - urbtrack->setup = kmalloc(sizeof(*urbtrack->setup), GFP_KERNEL);
    + urbtrack->setup = kmalloc(sizeof(*urbtrack->setup), GFP_ATOMIC);
    if (!urbtrack->setup) {
    usb_free_urb(urbtrack->urb);
    kfree(urbtrack);


    \
     
     \ /
      Last update: 2013-10-21 11:41    [W:2.243 / U:0.876 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site