lkml.org 
[lkml]   [2013]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] percpu_ida: Removing unused arguement from alloc_local_tag
From
Date
On Wed, 2013-10-02 at 17:55 -0700, Nick Swenson wrote:
> Removing unused struct percpu_ida *pool from arguemnts of
> alloc_local_tag, changed it's one use in idr.c
>
> Signed-Off-By: Nick Swenson <nks@daterainc.com>
> ---

Nice patch, but the upstream version of percpu_ida lives in
lib/percpu_ida.c, and not lib/idr.c. :-)

Soooo, modified your patch to use this location instead, and applied
target-pending/for-next.

Thanks!

--nab

> lib/idr.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/idr.c b/lib/idr.c
> index 26495e1..86e8f73 100644
> --- a/lib/idr.c
> +++ b/lib/idr.c
> @@ -1254,8 +1254,7 @@ static inline void alloc_global_tags(struct percpu_ida *pool,
> min(pool->nr_free, IDA_PCPU_BATCH_MOVE));
> }
>
> -static inline unsigned alloc_local_tag(struct percpu_ida *pool,
> - struct percpu_ida_cpu *tags)
> +static inline unsigned alloc_local_tag(struct percpu_ida_cpu *tags)
> {
> int tag = -ENOSPC;
>
> @@ -1291,7 +1290,7 @@ int percpu_ida_alloc(struct percpu_ida *pool, gfp_t gfp)
> tags = this_cpu_ptr(pool->tag_cpu);
>
> /* Fastpath */
> - tag = alloc_local_tag(pool, tags);
> + tag = alloc_local_tag(tags);
> if (likely(tag >= 0)) {
> local_irq_restore(flags);
> return tag;




\
 
 \ /
  Last update: 2013-10-03 03:21    [W:0.039 / U:26.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site