lkml.org 
[lkml]   [2013]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [LNG] [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler
From
On 2 October 2013 19:43, Kim Phillips <kim.phillips@linaro.org> wrote:
> On Wed, 2 Oct 2013 14:08:44 +0300
> Taras Kondratiuk <taras.kondratiuk@linaro.org> wrote:
>
>> From: Danke Xie <d.xie@sta.samsung.com>
>>
>> The current TWL 6030 IRQ handler assumes little endianness.
>> This change makes it endian-neutral.
>>
>> Signed-off-by: Danke Xie <d.xie@sta.samsung.com>
>> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
>> ---
>
> this patch causes a new sparse warning:
>
> make C=2 CF="-D__CHECK_ENDIAN__" drivers/mfd/twl6030-irq.o
> ...
> CHECK drivers/mfd/twl6030-irq.c
> drivers/mfd/twl6030-irq.c:200:19: warning: cast to restricted __le32
>
> does int_sts in the sts union need to be defined as __le32?

You are right.
I will update the patch.

--
Regards,
Taras Kondratiuk


\
 
 \ /
  Last update: 2013-10-02 23:41    [W:0.057 / U:3.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site