lkml.org 
[lkml]   [2013]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/4] kconfig: remove unused definition from scanner
Date
Martin, All,

On Wednesday 02 October 2013 08:42:59 Dirk Gouders wrote:
> Martin Walch <walch.martin@web.de> writes:
>
> > From: Martin Walch <walch.martin@web.de>
> > Date: Wed, 2 Oct 2013 06:58:46 +0200
> > Subject: [PATCH 4/4] kconfig: remove unused definition from scanner
> >
> > The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion.
>
> Hi Martin,
>
> I think you should also regenerate the scanner and add
> the new zconf.lex.c_shipped to this patch.

I think sending the re-generated parser as a separate patch helps
in reviewing. Ie. I'd prefer a fifth patch.

BTW, regenerating the parser can be done with:
make REGENERATE_PARSERS=1 config

Regards,
Yann E. MORIN.

> > Signed-off-by: Martin Walch <walch.martin@web.de>
> > ---
> > scripts/kconfig/zconf.l | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l
> > index 6555a47..1a9f53e 100644
> > --- a/scripts/kconfig/zconf.l
> > +++ b/scripts/kconfig/zconf.l
> > @@ -68,7 +68,6 @@ static void alloc_string(const char *str, int size)
> > }
> > %}
> >
> > -ws [ \n\t]
> > n [A-Za-z0-9_]
> >
> > %%
>

--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'


\
 
 \ /
  Last update: 2013-10-02 09:21    [W:0.079 / U:74.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site