[lkml]   [2013]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Staging : android: binder.c: Prefer seq_puts to seq_printf
On Wed, 2013-10-02 at 15:15 +1000, Ryan Mallon wrote:
> On 02/10/13 11:57, Mathieu Rhéaume wrote:
> > This patch changes seq_printf for seq_puts in binder.c.
> > It fixes the warnings emitted by
> Umm, this won't compile. seq_puts() is defined as:
> int seq_puts(struct seq_file *m, const char *s);
> does indeed complain about uses of seq_printf() in
> drivers/staging/android/binder.c which are passing formatted strings. At
> a quick glance it looks like is only checking for the
> format string on the same line as seq_printf(), so this files ugly
> coding style confuses the check. Joe?


This patch should have fixed it. It's in -next already.

> Anyway, please don't blindly change things in the kernel without at
> least compile testing them.

Yes, please.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2013-10-02 09:01    [W:0.069 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site