Messages in this thread | | | Date | Wed, 2 Oct 2013 08:40:53 +0300 | From | Arto Merilainen <> | Subject | Re: [PATCHv3 4/4] gpu: host1x: Add runtime pm support for host1x |
| |
On 10/01/2013 09:17 PM, Stephen Warren wrote: > On 09/24/2013 06:05 AM, Arto Merilainen wrote: >> From: Mayuresh Kulkarni <mkulkarni@nvidia.com> >> >> This patch adds runtime pm support for host1x hardware unit. This >> allows host1x clock to be turned off when it is idle. If pm runtime >> is not configured, we enable host1x clock in device probe and disable >> it in remove. > >> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c > >> +static int host1x_runtime_suspend(struct device *dev); >> +static int host1x_runtime_resume(struct device *dev); > > You could avoid having these prototypes by simply putting the function > bodies earlier on in the file, somewhere before they're used. I don't > care much either way, but I've certainly seen some people care about > this and ask for them to be moved.
Will fix.
- Arto
| |