Messages in this thread | | | Date | Wed, 2 Oct 2013 08:20:41 -0400 | From | Jason Cooper <> | Subject | Re: [PATCH 2/3] net: mv643xx_eth: fix orphaned statistics timer crash |
| |
On Wed, Oct 02, 2013 at 12:57:21PM +0200, Sebastian Hesselbarth wrote: > The periodic statistics timer gets started at port _probe() time, but > is stopped on _stop() only. In a modular environment, this can cause > the timer to access already deallocated memory, if the module is unloaded > without starting the eth device. To fix this, we add the timer right > before the port is started, instead of at _probe() time. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > --- > Cc: David Miller <davem@davemloft.net> > Cc: Lennert Buytenhek <buytenh@wantstofly.org> > Cc: Jason Cooper <jason@lakedaemon.net> > Cc: netdev@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Jason Cooper <jason@lakedaemon.net>
Introduced by:
4ff3495a mv643xx_eth: enforce frequent hardware statistics polling
which also goes all the way back to v2.6.28
thx,
Jason.
| |