lkml.org 
[lkml]   [2013]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] kconfig: adjust warning message for conflicting types
On Wed, 2 Oct 2013, Martin Walch wrote:

> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index b970101..e511df5 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -119,7 +119,7 @@ void menu_set_type(int type)
> sym->type = type;
> return;
> }
> - menu_warn(current_entry, "type of '%s' redefined from '%s' to '%s'",
> + menu_warn(current_entry, "type of '%s' not redefined from '%s' to '%s'",
> sym->name ? sym->name : "<choice>",
> sym_type_name(sym->type), sym_type_name(type));
> }

The warning is stating that the symbol was attempted to be redefined from
one type to another, not that it was successful, so I don't think this
patch actually helps make anything clearer. (gcc warns when a symbol is
redefined by saying "redefintion of `blah`".) Perhaps include that the
redefinition was ignored?


\
 
 \ /
  Last update: 2013-10-02 07:41    [W:0.066 / U:6.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site