lkml.org 
[lkml]   [2013]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] perf tools: Separate lbfd check out of NO_DEMANGLE condition

* Namhyung Kim <namhyung@kernel.org> wrote:

> Hi Jiri,
>
> On Wed, 2 Oct 2013 10:17:57 +0200, Jiri Olsa wrote:
> > On Wed, Oct 02, 2013 at 10:18:32AM +0900, Namhyung Kim wrote:
> >> It seems that it needs libdl for loading plugins. Adding -ldl makes
> >> above build successfully. So we need to add -ldl for EXTLIBS IMHO.
> >> Without it, make NO_GTK2=1 NO_LIBPERL=1 NO_LIBPYTHON=1 will fail to
> >> check libbfd correctly (FYI, libperl and libpython add -ldl to the
> >> dependency list).
> >
> > hum, so on my system -liberty check wins without -lbfd, so 'NO_GTK2=1
> > NO_LIBPERL=1 NO_LIBPYTHON=1' passes
> >
> > I need to check Ingo's latest changes on this, not sure how if this
> > problem is relevant any longer ;-)
>
> AFAICS, Ingo's patch does "-lbfd -ldl" rather than "-lbfd". So probably
> there's no problem then. :)

I didn't fully demangle the maze of demangler feature tests yet :-) I
added a single testcase, the rest is still detected using the old method.

Any assymetry in detection is probably a bug in my patches.

If that nested series of conditions is really necessary then we can add
separate testcases for each, the same file built with different linker
flags.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-02 12:41    [W:0.057 / U:2.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site