Messages in this thread | | | Date | Sat, 19 Oct 2013 19:42:35 -0300 | Subject | Re: [PATCH] crypto: n2_core: insert '!err' condition in else scope | From | Geyslan Gregório Bem <> |
| |
2013/10/19 David Miller <davem@davemloft.net>: > From: "Geyslan G. Bem" <geyslan@gmail.com> > Date: Sat, 19 Oct 2013 10:09:31 -0300 > >> This patch moves the '!err' condition into the above else scope, >> what is more obvious and has the secondary goal of avoid false-positives >> in statical analyze tools. >> >> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> > > I do not think patches should be applied to satisfy tools if the > code is semantically correct.
Yes, Miller, I agree. But as I mentioned: ".. and has as the 'secondary' goal of avoid false-positives in statical analyze tools."
The 'primary' goal is to not repeat a condition test: "This patch moves the '!err' condition into the above else scope, what is more obvious ..."
Thanks.
| |