lkml.org 
[lkml]   [2013]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 08/11] watchdog: ts72xx_wdt: locking bug in ioctl
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 8612ed0d97abcf1c016d34755b7cf2060de71963 upstream.

    Calling the WDIOC_GETSTATUS & WDIOC_GETBOOTSTATUS and twice will cause a
    interruptible deadlock.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
    Cc: Jonghwan Choi <jhbird.choi@samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/watchdog/ts72xx_wdt.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/watchdog/ts72xx_wdt.c
    +++ b/drivers/watchdog/ts72xx_wdt.c
    @@ -310,7 +310,8 @@ static long ts72xx_wdt_ioctl(struct file

    case WDIOC_GETSTATUS:
    case WDIOC_GETBOOTSTATUS:
    - return put_user(0, p);
    + error = put_user(0, p);
    + break;

    case WDIOC_KEEPALIVE:
    ts72xx_wdt_kick(wdt);



    \
     
     \ /
      Last update: 2013-10-18 22:01    [W:2.034 / U:1.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site