Messages in this thread | | | Date | Fri, 18 Oct 2013 11:31:13 -0600 | From | David Ahern <> | Subject | Re: [PATCH v2 4/4] perf-top: add --max-stack option to limit callchain stack scan |
| |
On 10/18/13 8:38 AM, Waiman Long wrote: > When the callgraph function is enabled (-G), it may take a long time to > scan all the stack data and merge them accordingly. > > This patch adds a new --max-stack option to perf-top to limit the depth > of callchain stack data to look at to reduce the time it takes for > perf-top to finish its processing. It reduces the amount of information > provided to the user in exchange for faster speed. > > Signed-off-by: Waiman Long <Waiman.Long@hp.com> > --- > tools/perf/Documentation/perf-top.txt | 8 ++++++++ > tools/perf/builtin-top.c | 8 ++++++-- > tools/perf/util/top.h | 1 + > 3 files changed, 15 insertions(+), 2 deletions(-) >
Looks good to me. Acked-by: David Ahern <dsahern@gmail.com>
| |