lkml.org 
[lkml]   [2013]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: honor ACPI FADT flag indicating absence of a CMOS RTC

* Jan Beulich <JBeulich@suse.com> wrote:

> We shouldn't be creating a corresponding platform device in that case.

There's a sad lack of context in the changelog, how was it found, does
this address any problem/bug observed in practice, etc?

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> ---
> arch/x86/kernel/rtc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --- 3.12-rc5/arch/x86/kernel/rtc.c
> +++ 3.12-rc5-x86-ACPI-no-RTC/arch/x86/kernel/rtc.c
> @@ -192,6 +192,11 @@ static __init int add_rtc_cmos(void)
> if (mrst_identify_cpu())
> return -ENODEV;
>
> +#ifdef CONFIG_ACPI
> + if (acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC)
> + return -ENODEV;
> +#endif

It might also be prudent to emit a KERN_INFO line telling that we don't
create the device - so that people who suddenly see unexpected breakage or
change in behavior have a chance to see what we've done?

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-18 08:41    [W:0.068 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site