lkml.org 
[lkml]   [2013]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 06/15] clk: tegra: move fields to tegra_clk_pll_params
On Fri, Oct 18, 2013 at 12:59:30AM +0200, Andrew Bresticker wrote:
> Hi Peter,
>
> > @@ -1682,17 +1664,15 @@ struct clk *tegra_clk_register_pllc(const char *name, const char *parent_name,
> > struct clk *tegra_clk_register_plle_tegra114(const char *name,
> > const char *parent_name,
> > void __iomem *clk_base, unsigned long flags,
> > - unsigned long fixed_rate,
> > struct tegra_clk_pll_params *pll_params,
> > - struct tegra_clk_pll_freq_table *freq_table,
> > spinlock_t *lock)
> > {
> > struct tegra_clk_pll *pll;
> > struct clk *clk;
> > u32 val, val_aux;
> >
> > - pll = _tegra_init_pll(clk_base, NULL, fixed_rate, pll_params,
> > - TEGRA_PLL_HAS_LOCK_ENABLE, freq_table, lock);
> > + pll_params->flags = TEGRA_PLL_HAS_LOCK_ENABLE;
>
> Why are we just overwriting the flags? We pass in flags here:
>
> > @@ -661,6 +685,9 @@ static struct tegra_clk_pll_params pll_e_params = {
> > .lock_enable_bit_idx = PLLE_MISC_LOCK_ENABLE,
> > .lock_delay = 300,
> > .div_nmp = &plle_nmp,
> > + .freq_table = pll_e_freq_table,
> > + .flags = TEGRA_PLL_FIXED,
>
> TEGRA_PLL_FIXED doesn't actually make a difference in the
> plle_tegra114 case, but it would be nice to be correct about setting
> it.

Yeah indeed.

Cheers,

Peter.


\
 
 \ /
  Last update: 2013-10-18 14:41    [W:0.042 / U:2.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site