lkml.org 
[lkml]   [2013]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 03/15] clk: tegra: common periph_clk_enb_refcnt and clks
On Fri, Oct 18, 2013 at 12:26:20AM +0200, Andrew Bresticker wrote:
> Hi Peter,
>
> > static void __init tegra30_clock_init(struct device_node *np)
> > {
> > struct device_node *node;
> > - int i;
> >
> > clk_base = of_iomap(np, 0);
> > if (!clk_base) {
> > @@ -1916,8 +1910,11 @@ static void __init tegra30_clock_init(struct device_node *np)
> > BUG();
> > }
> >
> > - if (tegra_clk_set_periph_banks(5) < 0)
> > + clks = tegra_clk_init(clk_max, 5);
> > + if (!clks) {
> > + WARN_ON(1);
>
> Really minor nit: it seems strange that we WARN here for t30, but not
> for t114 or t20.

There used to be a warning for all 3, but I removed it and apparently forgot
t30.

Cheers,

Peter.


\
 
 \ /
  Last update: 2013-10-18 14:41    [W:0.050 / U:4.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site