lkml.org 
[lkml]   [2013]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 02/15] clk: tegra: simplify periph clock data
From
Hi Peter,

> @@ -2346,6 +2247,9 @@ static void __init tegra114_clock_init(struct device_node *np)
> if (tegra114_osc_clk_init(clk_base) < 0)
> return;
>
> + if (tegra_clk_set_periph_banks(5) < 0)

Maybe it would be better to have a #define for this (e.g.
TEGRAxxx_CLK_PERIPH_BANKS)? Same goes for t20 and t30.

> /* Global data of Tegra CPU CAR ops */
> static struct tegra_cpu_car_ops dummy_car_ops;
> struct tegra_cpu_car_ops *tegra_cpu_car_ops = &dummy_car_ops;
>
> +int *periph_clk_enb_refcnt;

This changes seems unrelated. Perhaps it should go in the one that
makes the common periph_clk_enb_refcnt?

Thanks,
Andrew


\
 
 \ /
  Last update: 2013-10-18 00:21    [W:0.028 / U:2.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site