lkml.org 
[lkml]   [2013]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] perf: disable PERF_RECORD_MMAP2 support
Em Thu, Oct 17, 2013 at 07:32:15PM +0200, Stephane Eranian escreveu:
>
> For now, we disable the extended MMAP record support (MMAP2).
> We have identified cases where it would not report the correct
> mapping information, clone(VM_CLONE) but with separate pids.
> We will revisit the support once we find a solution for this case.
>
> The patch changes the kernel to return EINVAL if attr->mmap2
> is set. The patch also modifies the perf tool to use regular PERF_RECORD_MMAP
> for synthetic events and it also prevents the tool from requesting attr->mmap2
> mode because the kernel would reject it.
>
> The support will be revisited once the kenrel interface is updated.
>
> In V2, we reduce the patch to the strict minimum.
> In V3, we avoid calling perf_event_open() with mmap2 set because we
> know it will fail and require fallback retry.

Again it applied, but with some fuzz, which branch did you coded this
against? Testing...

[acme@zoo linux]$ patch -p1 < /wb/1
patching file kernel/events/core.c
Hunk #1 succeeded at 6767 (offset -6 lines).
patching file tools/perf/util/event.c
patching file tools/perf/util/evsel.c
Hunk #1 succeeded at 678 with fuzz 1.
[acme@zoo linux]$

- Arnaldo


\
 
 \ /
  Last update: 2013-10-17 21:41    [W:0.030 / U:7.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site