lkml.org 
[lkml]   [2013]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status
On Thu, Oct 17, 2013 at 04:27:55PM +0200, Sebastian Andrzej Siewior wrote:
> On Thu, Oct 17, 2013 at 07:37:45AM +0530, Vinod Koul wrote:
> > index 0bc7275..683c380 100644
> > --- a/include/linux/dmaengine.h
> > +++ b/include/linux/dmaengine.h
> > @@ -45,16 +45,17 @@ static inline int dma_submit_error(dma_cookie_t cookie)
> >
> > /**
> > * enum dma_status - DMA transaction status
> > - * @DMA_SUCCESS: transaction completed successfully
> > + * @DMA_COMPLETE: transaction completed
> > * @DMA_IN_PROGRESS: transaction not yet processed
> > * @DMA_PAUSED: transaction is paused
> > * @DMA_ERROR: transaction failed
> > */
> > enum dma_status {
> > - DMA_SUCCESS,
> > + DMA_COMPLETE,
> > DMA_IN_PROGRESS,
> > DMA_PAUSED,
> > DMA_ERROR,
> > + DMA_SUCCESS,
> > };
>
> There are some drivers which compare against == or != DMA_SUCCESS. Shouldn't this
> become
> enum dma_status {
> - DMA_SUCCESS,
> + DMA_COMPLETE = 0, DMA_SUCCESS = 0,
> DMA_IN_PROGRESS,
> DMA_PAUSED,
> DMA_ERROR,
> };
>
> so nothing breaks during the transition?
Yes i missed it in first place update the patch to fix that

~Vinod


\
 
 \ /
  Last update: 2013-10-17 17:01    [W:0.101 / U:11.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site