lkml.org 
[lkml]   [2013]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completion status
Hi Sebastian

On Thu, 17 Oct 2013, Sebastian Andrzej Siewior wrote:

> On Thu, Oct 17, 2013 at 07:37:45AM +0530, Vinod Koul wrote:
> > index 0bc7275..683c380 100644
> > --- a/include/linux/dmaengine.h
> > +++ b/include/linux/dmaengine.h
> > @@ -45,16 +45,17 @@ static inline int dma_submit_error(dma_cookie_t cookie)
> >
> > /**
> > * enum dma_status - DMA transaction status
> > - * @DMA_SUCCESS: transaction completed successfully
> > + * @DMA_COMPLETE: transaction completed
> > * @DMA_IN_PROGRESS: transaction not yet processed
> > * @DMA_PAUSED: transaction is paused
> > * @DMA_ERROR: transaction failed
> > */
> > enum dma_status {
> > - DMA_SUCCESS,
> > + DMA_COMPLETE,
> > DMA_IN_PROGRESS,
> > DMA_PAUSED,
> > DMA_ERROR,
> > + DMA_SUCCESS,
> > };
>
> There are some drivers which compare against == or != DMA_SUCCESS. Shouldn't this
> become
> enum dma_status {
> - DMA_SUCCESS,
> + DMA_COMPLETE = 0, DMA_SUCCESS = 0,
> DMA_IN_PROGRESS,
> DMA_PAUSED,
> DMA_ERROR,
> };
>
> so nothing breaks during the transition?

Good catch. I would do

enum dma_status {
- DMA_SUCCESS,
+ DMA_COMPLETE,
DMA_IN_PROGRESS,
DMA_PAUSED,
DMA_ERROR,
};

+ #define DMA_SUCCESS DMA_COMPLETE

and then just remove the last line again

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/


\
 
 \ /
  Last update: 2013-10-17 17:01    [W:0.105 / U:7.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site