lkml.org 
[lkml]   [2013]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [bug] get_maintainer.pl incomplete output
On Wed, 16 Oct 2013, Joe Perches wrote:

> > I haven't looked closely at scripts/get_maintainer.pl, but I recently
> > wrote a patch touching mm/vmpressure.c and it doesn't list the file's
> > author, Anton Vorontsov <anton.vorontsov@linaro.org>.
> >
> > Even when I do scripts/get_maintainer.pl -f mm/vmpressure.c, his entry is
> > missing and git blame attributs >90% of the lines to his authorship.
> >
> > $ ./scripts/get_maintainer.pl -f mm/vmpressure.c
> > Tejun Heo <tj@kernel.org> (commit_signer:6/7=86%)
> > Michal Hocko <mhocko@suse.cz> (commit_signer:5/7=71%)
> > Andrew Morton <akpm@linux-foundation.org> (commit_signer:4/7=57%)
> > Li Zefan <lizefan@huawei.com> (commit_signer:3/7=43%)
> > "Kirill A. Shutemov" <kirill@shutemov.name> (commit_signer:1/7=14%)
> > linux-mm@kvack.org (open list:MEMORY MANAGEMENT)
> > linux-kernel@vger.kernel.org (open list)
> >
> > Any ideas?
>
> get_maintainer has a lot of options.
>
> get_maintainer tries to find people that are either
> listed in the MAINTAINERS file or that have recently
> (in the last year by default) worked on the file.
>
> If you want to find all authors, use the --git-blame option
>
> It's not the default because it can take quite awhile to run.
>

Hmm, it's a little strange to only consider recent activity when >90% of
the lines were written by someone not listed. Isn't there any faster way
to determine that besides using the expensive git blame? Something like
weighing the output of "git show --shortstat" for all commits in "git log
mm/vmpressure.c" to determine the most important recent changes? That
should be fairly cheap.


\
 
 \ /
  Last update: 2013-10-17 06:41    [W:0.096 / U:2.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site