Messages in this thread | | | Date | Thu, 17 Oct 2013 11:24:55 +0900 | From | Yasuaki Ishimatsu <> | Subject | Re: [PATCH] Release device_hotplug_lock when store_mem_state returns EINVAL |
| |
(2013/10/12 1:31), Toshi Kani wrote: > On Fri, 2013-10-11 at 15:36 +0900, Yasuaki Ishimatsu wrote: >> When inserting a wrong value to /sys/devices/system/memory/memoryX/state file, >> following messages are shown. And device_hotplug_lock is never released. >> >> ================================================ >> [ BUG: lock held when returning to user space! ] >> 3.12.0-rc4-debug+ #3 Tainted: G W >> ------------------------------------------------ >> bash/6442 is leaving the kernel with locks still held! >> 1 lock held by bash/6442: >> #0: (device_hotplug_lock){+.+.+.}, at: [<ffffffff8146cbb5>] lock_device_hotplug_sysfs+0x15/0x50 >> >> This issue was introdued by commit fa2be40 (drivers: base: use standard >> device online/offline for state change). >> >> This patch releases device_hotplug_lcok when store_mem_state returns EINVAL. >> >> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> >> CC: Toshi Kani <toshi.kani@hp.com> >> CC: Seth Jennings <sjenning@linux.vnet.ibm.com> >> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Good catch! > > Reviewed-by: Toshi Kani <toshi.kani@hp.com>
Thank you for your review.
Thanks, Yasuaki Ishimatsu
> > Thanks, > -Toshi >
| |