lkml.org 
[lkml]   [2013]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf, x86: Optimize intel_pmu_pebs_fixup_ip()
> So avoid having to call copy_from_user_nmi() for every instruction.
> Since we already limit the max basic block size, we can easily
> pre-allocate a piece of memory to copy the entire thing into in one
> go.

It would be better/more generic if you split copy_from_user_nmi() into
init() copy() end()

(and some state that checks if the underlying page changes)

Then first you don't need the buffer and it could be also
be applied to the other cases, like the stack unwinding,
where copying everything is likely too slow.

-Andi


\
 
 \ /
  Last update: 2013-10-16 23:01    [W:0.175 / U:8.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site