lkml.org 
[lkml]   [2013]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/5] uprobes: fix fork() with the pending ret-probe(s)
On 10/14, Oleg Nesterov wrote:
>
> On 10/13, Oleg Nesterov wrote:
> >
> > Please review, this series fixes the serious bug reported by
> > Martin and David and cc's stable. See the changelog in 5/5.

OK, nobody seems to object, I am going to ask Ingo to pull this fix.

But,

> This probably needs another patch to handle the special case, vfork().
> In this case it would be more correct to dup return_instances but
> (obviously) avoid dup_xol_area.
>
> However I think this is not that important, the child should not "unwind"
> the stack if it shares mm/stack with its parent, otherwise it can corrupt
> the parent's stack.

Yes, but I forgot that at least the child should return from vfork()
itself and it can be ret-probed.

So I am sending the additional 6/5 in reply to 0/5. This change can
be joined with 1/5, but I'd prefer to do this in a separate patch for
better documentation.

Oleg.



\
 
 \ /
  Last update: 2013-10-16 21:41    [W:0.203 / U:4.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site