lkml.org 
[lkml]   [2013]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 03/12] mm, thp, tmpfs: handle huge page cases in shmem_getpage_gfp
Great! Thanks!
Best wishes,
--
Ning Qu (曲宁) | Software Engineer | quning@google.com | +1-408-418-6066


On Wed, Oct 16, 2013 at 5:11 AM, Kirill A. Shutemov
<kirill.shutemov@linux.intel.com> wrote:
> Ning Qu wrote:
>> you mean something like this? If so, then fixed.
>>
>> if (must_use_thp) {
>> page = shmem_alloc_hugepage(gfp, info, index);
>> if (page) {
>> count_vm_event(THP_WRITE_ALLOC);
>> } else
>> count_vm_event(THP_WRITE_ALLOC_FAILED);
>> } else {
>> page = shmem_alloc_page(gfp, info, index);
>> }
>>
>> if (!page) {
>> error = -ENOMEM;
>> goto unacct;
>> }
>> nr = hpagecache_nr_pages(page);
>
> Yeah.
>
> count_vm_event() part still looks ugly, but I have similar in my code.
> I'll think more how to rework in to make it better.
>
> --
> Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-10-16 20:21    [W:0.060 / U:4.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site