Messages in this thread | | | Date | Wed, 16 Oct 2013 11:02:50 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v3 14/19] clk: tegra30: replace enum by binding header |
| |
On 10/16/2013 08:46 AM, Peter De Schrijver wrote: > On Tue, Oct 15, 2013 at 09:41:57PM +0200, Stephen Warren wrote: >> On 10/15/2013 08:52 AM, Peter De Schrijver wrote: >>> As the clock IDs are now specified in a header file, we can use those >>> definitions instead of maintaining an internal enum. >> >> Nit: The patch subject should say "clk: tegra:" not "clk: tegra20:" so >> that anyone looking at the tags in the subject has only one "tegra" >> value to look at, not a whole bunch of them. >> >> Would it make sense to squash patches 15, 16, 18 together (and similar >> for Tegra30) to avoid some churn i.e. the fact that the entire body of >> tegra_periph_clk_list[] gets replaced twice? > > You mean do all the changes for Tegra20 and Tegra30 in 1 patch per SoC?
Yes. I think it'd make the patches smaller. But it's probably not a big deal if you disagree.
| |