lkml.org 
[lkml]   [2013]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] uprobes: Change uprobe_copy_process() to dup xol_area
On 10/16, Srikar Dronamraju wrote:
>
> * Oleg Nesterov <oleg@redhat.com> [2013-10-13 21:18:44]:
>
> > We know that this vaddr is fine for install_special_mapping(), the
> > necessary hole was recently "created" by dup_mmap() which skips the
> > parent's VM_DONTCOPY area, and nobody else could use the new mm.
>
>
> I was actually thinking if we can remove the VM_DONTCOPY from
> install_special_mapping,

I considered this option. I even thought about playing with vm_flags
in uprobe_start/stop_dup_mmap ;)

> But there are obvious issues with that approach

and we simply can't do this. Unlike, say, vdso xol vma can not be
cloned automatically, we obviously can't use the same area->page.
Plus we need to dup area itself, at least for ->bitmap.

> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Thanks!

Oleg.



\
 
 \ /
  Last update: 2013-10-16 18:41    [W:0.071 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site