lkml.org 
[lkml]   [2013]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/6] percpu: Add preemption checks to __this_cpu ops
On Wed, Oct 16, 2013 at 03:09:13PM +0000, Christoph Lameter wrote:
> On Wed, 16 Oct 2013, Peter Zijlstra wrote:
>
> > So I didn't understand what was wrong with:
> >
> > #define __this_cpu_read(pcp) \
> > (__this_cpu_preempt_check("read"), raw_this_cpu_read(pcp))
> >
> > And idem for all others. This is 1) shorter to write; and 2) makes it
> > blindingly obvious that the implementations are actually the same.
>
> Nothing wrong with that. It just increases the scope of this patch to
> require modifications to arch code and I already have trouble enough
> following through on all the issues that were raised so far.
>

But non of your raw ops touch arch code... /me confused.


\
 
 \ /
  Last update: 2013-10-16 18:01    [W:0.060 / U:3.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site