lkml.org 
[lkml]   [2013]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] net: ip4_datagram_connect: Use correct form of statistics update

* Eric Dumazet <eric.dumazet@gmail.com> wrote:

> On Tue, 2013-10-15 at 12:47 -0500, Christoph Lameter wrote:
> > plain text document attachment (fix_snmp)
> > ip4_datagram_connect is called with BH processing enabled. Therefore
> > we cannot use IP_INC_STATS_BH but must use IP_INC_STATS which disables
> > BH handling before incrementing the counter.
> >
> > The following trace is triggered without this patch:
>
> > Cc: Eric Dumazet <edumazet@google.com>
> > Cc: netdev@vger.kernel.org
> > Cc: David Miller <davem@davemloft.net>
> > Signed-off-by: Christoph Lameter <cl@linux.com>
>
> Strange, I thought I already Acked it...
>
> Acked-by: Eric Dumazet <edumazet@google.com>

Christoph, _please_ pick up people's Acked-by's in the future ... This is
basic courtesy towards reviewers.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-16 08:21    [W:0.178 / U:1.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site