lkml.org 
[lkml]   [2013]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PM/AVS: SmartReflex: fix fake probe success on debugfs fail
On 10/16/2013 06:40 AM, Vishwanathrao Badarkhe, Manish wrote:
> From: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>
>
> Currently, probe returns success(0) on "debugfs_create_dir"
> function call failed. Return proper error on "debugfs_create_dir"
> call failed.
>
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
> ---
> Not tested on any EVM. Bug has been found while doing static review.
> Please confirm.


IMHO, fail of creation of debugfs is not reason enough to fail the
probe - further, this code needs a major revamp to work with device tree.

>
> :100644 100644 db9973b... 7b101c1... M drivers/power/avs/smartreflex.c
> drivers/power/avs/smartreflex.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index db9973b..7b101c1 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -921,7 +921,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
> if (!sr_dbg_dir) {
> sr_dbg_dir = debugfs_create_dir("smartreflex", NULL);
> if (IS_ERR_OR_NULL(sr_dbg_dir)) {
> - ret = PTR_ERR(sr_dbg_dir);
> + ret = sr_dbg_dir ? PTR_ERR(sr_dbg_dir) : -EIO;
> pr_err("%s:sr debugfs dir creation failed(%d)\n",
> __func__, ret);
> goto err_list_del;
> @@ -932,7 +932,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
> if (IS_ERR_OR_NULL(sr_info->dbg_dir)) {
> dev_err(&pdev->dev, "%s: Unable to create debugfs directory\n",
> __func__);
> - ret = PTR_ERR(sr_info->dbg_dir);
> + ret = sr_info->dbg_dir ? PTR_ERR(sr_info->dbg_dir) : -EIO;
> goto err_debugfs;
> }
>
> @@ -947,7 +947,7 @@ static int __init omap_sr_probe(struct platform_device *pdev)
> if (IS_ERR_OR_NULL(nvalue_dir)) {
> dev_err(&pdev->dev, "%s: Unable to create debugfs directory"
> "for n-values\n", __func__);
> - ret = PTR_ERR(nvalue_dir);
> + ret = nvalue_dir ? PTR_ERR(nvalue_dir) : -EIO;
> goto err_debugfs;
> }
>
>

--
Regards,
Nishanth Menon


\
 
 \ /
  Last update: 2013-10-16 16:21    [W:0.048 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site