lkml.org 
[lkml]   [2013]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] uprobes: Introduce __create_xol_area()
* Oleg Nesterov <oleg@redhat.com> [2013-10-13 21:18:35]:

> No functional changes, preparation.
>
> Extract the code which actually allocates/installs the new area
> into the new helper, __create_xol_area().
>
> While at it remove the unnecessary "ret = ENOMEM" and "ret = 0"
> in xol_add_vma(), they both have no effect.
>
> Cc: stable@vger.kernel.org # 3.9+
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

One nit below.

>
> /* Slot allocation for XOL */
> -static int xol_add_vma(struct xol_area *area)
> +static int xol_add_vma(struct mm_struct *mm, struct xol_area *area)
> {
> - struct mm_struct *mm = current->mm;
> int ret = -EALREADY;
>
> down_write(&mm->mmap_sem);
> if (mm->uprobes_state.xol_area)
> goto fail;
>
> - ret = -ENOMEM;
> - /* Try to map as high as possible, this is only a hint. */
> + /* Try to map as high as possible, this is only a hint. */

Nit: This comment seems to be shifted unnecessarily.


--
Thanks and Regards
Srikar Dronamraju



\
 
 \ /
  Last update: 2013-10-16 15:21    [W:0.234 / U:2.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site