lkml.org 
[lkml]   [2013]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 03/12] mm, thp, tmpfs: handle huge page cases in shmem_getpage_gfp
Date
Ning Qu wrote:
> you mean something like this? If so, then fixed.
>
> if (must_use_thp) {
> page = shmem_alloc_hugepage(gfp, info, index);
> if (page) {
> count_vm_event(THP_WRITE_ALLOC);
> } else
> count_vm_event(THP_WRITE_ALLOC_FAILED);
> } else {
> page = shmem_alloc_page(gfp, info, index);
> }
>
> if (!page) {
> error = -ENOMEM;
> goto unacct;
> }
> nr = hpagecache_nr_pages(page);

Yeah.

count_vm_event() part still looks ugly, but I have similar in my code.
I'll think more how to rework in to make it better.

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2013-10-16 15:01    [W:0.066 / U:2.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site