lkml.org 
[lkml]   [2013]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] net: ip4_datagram_connect: Use correct form of statistics update
On Tue, Oct 15, 2013 at 12:47:23PM -0500, Christoph Lameter wrote:
> ip4_datagram_connect is called with BH processing enabled. Therefore
> we cannot use IP_INC_STATS_BH but must use IP_INC_STATS which disables
> BH handling before incrementing the counter.
>
> The following trace is triggered without this patch:
>
> [ 9293.806634] __this_cpu_add operation in preemptible [00000000] code: ntpd/2150

You lost the BUG there; that really needs to be there:

- BUG makes people pay attention
- This was an actual BUG wasn't it?

Sure there can be false positives, but in all cases people should amend
the code. Sometimes with a comment explaining why the raw primitive
should be used; sometimes to fix an actual bug, but a patch needs to be
written. Therefore BUG!


\
 
 \ /
  Last update: 2013-10-16 11:01    [W:0.138 / U:1.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site