Messages in this thread | | | Subject | Re: [PATCH 2/8] ACPI, CPER: Update cper info | From | Joe Perches <> | Date | Tue, 15 Oct 2013 18:57:18 -0700 |
| |
On Fri, 2013-10-11 at 17:47 +0200, Borislav Petkov wrote: > On Fri, Oct 11, 2013 at 11:06:30AM +0200, Borislav Petkov wrote: > > > - printk("%s""APEI generic hardware error status\n", pfx); > > > + printk("%s""Generic Hardware Error Status\n", pfx); > > > > Btw, what's the story with printk not using KERN_x levels in this file? > > Why are we falling back to default printk levels for all printks here > > and shouldn't we rather prioritize them by urgency into, say, KERN_ERR, > > KERN_INFO, etc? > > Ignore that - checkpatch complained about it but I kinda missed that > we're handing down the prefix.
I think it'd be better to rename pfx to level as that's what printk.h calls them.
| |