lkml.org 
[lkml]   [2013]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 09/10] watchdog: Replace __get_cpu_var uses
    __get_cpu_var() is used for multiple purposes in the kernel source. One of
    them is address calculation via the form &__get_cpu_var(x). This calculates
    the address for the instance of the percpu variable of the current processor
    based on an offset.

    Other use cases are for storing and retrieving data from the current
    processors percpu area. __get_cpu_var() can be used as an lvalue when
    writing data or on the right side of an assignment.

    __get_cpu_var() is defined as :


    #define __get_cpu_var(var) (*this_cpu_ptr(&(var)))



    __get_cpu_var() always only does an address determination. However, store
    and retrieve operations could use a segment prefix (or global register on
    other platforms) to avoid the address calculation.

    this_cpu_write() and this_cpu_read() can directly take an offset into a
    percpu area and use optimized assembly code to read and write per cpu
    variables.


    This patch converts __get_cpu_var into either an explicit address
    calculation using this_cpu_ptr() or into a use of this_cpu operations that
    use the offset. Thereby address calculations are avoided and less registers
    are used when code is generated.

    At the end of the patch set all uses of __get_cpu_var have been removed so
    the macro is removed too.

    The patch set includes passes over all arches as well. Once these operations
    are used throughout then specialized macros can be defined in non -x86
    arches as well in order to optimize per cpu access by f.e. using a global
    register that may be set to the per cpu base.




    Transformations done to __get_cpu_var()


    1. Determine the address of the percpu instance of the current processor.

    DEFINE_PER_CPU(int, y);
    int *x = &__get_cpu_var(y);

    Converts to

    int *x = this_cpu_ptr(&y);


    2. Same as #1 but this time an array structure is involved.

    DEFINE_PER_CPU(int, y[20]);
    int *x = __get_cpu_var(y);

    Converts to

    int *x = this_cpu_ptr(y);


    3. Retrieve the content of the current processors instance of a per cpu
    variable.

    DEFINE_PER_CPU(int, y);
    int x = __get_cpu_var(y)

    Converts to

    int x = __this_cpu_read(y);


    4. Retrieve the content of a percpu struct

    DEFINE_PER_CPU(struct mystruct, y);
    struct mystruct x = __get_cpu_var(y);

    Converts to

    memcpy(&x, this_cpu_ptr(&y), sizeof(x));


    5. Assignment to a per cpu variable

    DEFINE_PER_CPU(int, y)
    __get_cpu_var(y) = x;

    Converts to

    this_cpu_write(y, x);


    6. Increment/Decrement etc of a per cpu variable

    DEFINE_PER_CPU(int, y);
    __get_cpu_var(y)++

    Converts to

    this_cpu_inc(y)

    Signed-off-by: Christoph Lameter <cl@linux.com>

    Index: linux/kernel/watchdog.c
    ===================================================================
    --- linux.orig/kernel/watchdog.c 2013-10-14 10:55:58.995077355 -0500
    +++ linux/kernel/watchdog.c 2013-10-14 10:58:05.687792286 -0500
    @@ -174,8 +174,8 @@ EXPORT_SYMBOL(touch_nmi_watchdog);

    void touch_softlockup_watchdog_sync(void)
    {
    - __raw_get_cpu_var(softlockup_touch_sync) = true;
    - __raw_get_cpu_var(watchdog_touch_ts) = 0;
    + __this_cpu_write(softlockup_touch_sync, true);
    + __this_cpu_write(watchdog_touch_ts, 0);
    }

    #ifdef CONFIG_HARDLOCKUP_DETECTOR
    @@ -341,7 +341,7 @@ static void watchdog_set_prio(unsigned i

    static void watchdog_enable(unsigned int cpu)
    {
    - struct hrtimer *hrtimer = &__raw_get_cpu_var(watchdog_hrtimer);
    + struct hrtimer *hrtimer = raw_cpu_ptr(&watchdog_hrtimer);

    /* kick off the timer for the hardlockup detector */
    hrtimer_init(hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
    @@ -361,7 +361,7 @@ static void watchdog_enable(unsigned int

    static void watchdog_disable(unsigned int cpu)
    {
    - struct hrtimer *hrtimer = &__raw_get_cpu_var(watchdog_hrtimer);
    + struct hrtimer *hrtimer = raw_cpu_ptr(&watchdog_hrtimer);

    watchdog_set_prio(SCHED_NORMAL, 0);
    hrtimer_cancel(hrtimer);
    @@ -488,7 +488,7 @@ static struct smp_hotplug_thread watchdo

    static void restart_watchdog_hrtimer(void *info)
    {
    - struct hrtimer *hrtimer = &__raw_get_cpu_var(watchdog_hrtimer);
    + struct hrtimer *hrtimer = raw_cpu_ptr(&watchdog_hrtimer);
    int ret;

    /*


    \
     
     \ /
      Last update: 2013-10-15 20:21    [W:3.805 / U:1.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site