lkml.org 
[lkml]   [2013]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: x86, perf: throttling issues with long nmi latencies
On Tue, Oct 15, 2013 at 10:36:31AM -0400, Don Zickus wrote:
> > > +refill:
> > > + if (kernel_ip(ip)) {
> > > + u8 *buf = &__get_cpu_var(insn_page[0]);
> > > + size = PAGE_SIZE - ((unsigned long)to & (PAGE_SIZE-1));
> > > + if (size < MAX_INSN_SIZE) {
> > > + /*
> > > + * If we're going to have to touch two pages; just copy
> > > + * as much as we can hold.
> > > + */
> > > + size = PAGE_SIZE;

> Quick thoughts?

Yeah, see the patch I just send; but notably I got the kernel_ip(ip)
case the wrong way about. See how it copies userspace memory for kernel
IPs and vice versa.




\
 
 \ /
  Last update: 2013-10-15 19:01    [W:0.117 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site